<AWT Dev> JDK 9 RFR of JDK-8075081 : Fix missing doclint warnings in java.awt

joe darcy joe.darcy at oracle.com
Fri Mar 27 17:07:46 UTC 2015


Hello,

Please review a fix for

     JDK-8075081 : Fix missing doclint warnings in java.awt
     http://cr.openjdk.java.net/~darcy/8075081.0/

Patch below.

Thanks,

-Joe

--- old/src/java.desktop/share/classes/java/awt/AWTEventMulticaster.java 
2015-03-27 10:04:02.689121176 -0700
+++ new/src/java.desktop/share/classes/java/awt/AWTEventMulticaster.java 
2015-03-27 10:04:02.537045172 -0700
@@ -1088,6 +1088,7 @@
       * contains only the specified listener. If no such listeners are 
chained,
       * this method returns an empty array.
       *
+     * @param <T> the listener type
       * @param l the specified <code>java.util.EventListener</code>
       * @param listenerType the type of listeners requested; this parameter
       *          should specify an interface that descends from
--- old/src/java.desktop/share/classes/java/awt/Component.java 
2015-03-27 10:04:03.117335190 -0700
+++ new/src/java.desktop/share/classes/java/awt/Component.java 
2015-03-27 10:04:02.965259185 -0700
@@ -4316,9 +4316,12 @@
           */
          protected boolean validatedContents; // = false
          /**
-         * Size of the back buffers
+         * Width of the back buffers
           */
          protected int width;
+        /**
+         * Height of the back buffers
+         */
          protected int height;

          /**
@@ -6013,6 +6016,7 @@
       *
       * If no such listeners exist, this method returns an empty array.
       *
+     * @param <T> the type of the listeners
       * @param listenerType the type of listeners requested; this parameter
       *          should specify an interface that descends from
       *          <code>java.util.EventListener</code>
--- old/src/java.desktop/share/classes/java/awt/MenuComponent.java 
2015-03-27 10:04:03.653603206 -0700
+++ new/src/java.desktop/share/classes/java/awt/MenuComponent.java 
2015-03-27 10:04:03.497525202 -0700
@@ -328,6 +328,7 @@
       * Its use is discouraged, and it may not be supported
       * in the future.
       * @param evt the event which is to take place
+     * @return unconditionally returns false
       * @deprecated As of JDK version 1.1, replaced by {@link
       * #dispatchEvent(AWTEvent) dispatchEvent}.
       */
--- old/src/java.desktop/share/classes/java/awt/MenuContainer.java 
2015-03-27 10:04:04.077815219 -0700
+++ new/src/java.desktop/share/classes/java/awt/MenuContainer.java 
2015-03-27 10:04:03.925739215 -0700
@@ -50,6 +50,7 @@
       * Posts an event to the listeners.
       *
       * @param  evt the event to dispatch
+     * @return the results of posting the event
       * @deprecated As of JDK version 1.1
       * replaced by dispatchEvent(AWTEvent).
       */
--- old/src/java.desktop/share/classes/java/awt/MenuItem.java 2015-03-27 
10:04:04.514033234 -0700
+++ new/src/java.desktop/share/classes/java/awt/MenuItem.java 2015-03-27 
10:04:04.365959229 -0700
@@ -595,6 +595,7 @@
       *
       * If no such listeners exist, this method returns an empty array.
       *
+     * @param <T> the type of the listeners
       * @param listenerType the type of listeners requested; this parameter
       *          should specify an interface that descends from
       *          <code>java.util.EventListener</code>
--- old/src/java.desktop/share/classes/java/awt/Toolkit.java 2015-03-27 
10:04:04.942247247 -0700
+++ new/src/java.desktop/share/classes/java/awt/Toolkit.java 2015-03-27 
10:04:04.786169242 -0700
@@ -1766,6 +1766,7 @@
       *
       * subclasses should override this to provide their own implementation
       *
+     * @param <T> the type of DragGestureRecognizer to create
       * @param abstractRecognizerClass The abstract class of the 
required recognizer
       * @param ds                      The DragSource
       * @param c                       The Component target for the 
DragGestureRecognizer
@@ -1867,7 +1868,9 @@
      }

      /**
-     * an opportunity to lazily evaluate desktop property values.
+     * An opportunity to lazily evaluate desktop property values.
+     * @return the desktop property or null
+     * @param name the name
       */
      protected Object lazilyLoadDesktopProperty(String name) {
          return null;
@@ -1947,8 +1950,14 @@
          return 
desktopPropsSupport.getPropertyChangeListeners(propertyName);
      }

+    /**
+     * The desktop properties.
+     */
      protected final Map<String,Object> desktopProperties =
              new HashMap<String,Object>();
+    /**
+     * The desktop properties change support.
+     */
      protected final PropertyChangeSupport desktopPropsSupport =
              Toolkit.createPropertyChangeSupport(this);

--- old/src/java.desktop/share/classes/java/awt/Window.java 2015-03-27 
10:04:05.378465260 -0700
+++ new/src/java.desktop/share/classes/java/awt/Window.java 2015-03-27 
10:04:05.230391255 -0700
@@ -2789,6 +2789,7 @@
      /**
       * @deprecated As of J2SE 1.4, replaced by
       * {@link Component#applyComponentOrientation 
Component.applyComponentOrientation}.
+     * @param rb the resource bundle
       */
      @Deprecated
      public void applyResourceBundle(ResourceBundle rb) {
@@ -2798,6 +2799,7 @@
      /**
       * @deprecated As of J2SE 1.4, replaced by
       * {@link Component#applyComponentOrientation 
Component.applyComponentOrientation}.
+     * @param rbName the resource name
       */
      @Deprecated
      public void applyResourceBundle(String rbName) {



More information about the awt-dev mailing list