<AWT Dev> [9] Review request for 8079255 [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Fri May 8 16:38:04 UTC 2015
Hi, Alexander.
Looks fine to me.
On 08.05.15 16:44, Alexander Scherbatiy wrote:
>
> Hello,
>
> Could you review the updated fix:
> http://cr.openjdk.java.net/~alexsch/8079255/webrev.01/
> - the first date is added to the copyright
> - the frame is disposed
>
> Thanks,
> Alexandr.
>
> On 5/7/2015 1:29 PM, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> Please dispose the frame at the end of the test. Also please update
>> the first date in the copyright.
>> It is interesting to think about a public api for mouse_wheel
>> rotation direction.
>>
>> On 07.05.15 12:44, Alexander Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8079255
>>> webrev: http://cr.openjdk.java.net/~alexsch/8079255/webrev.00
>>>
>>> The test does not take into account that the
>>> MouseWheelEvent.getWheelRotation() has reversed value on Mac OS X.
>>> The test is updated and moved to the open repository.
>>>
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>>
>
--
Best regards, Sergey.
More information about the awt-dev
mailing list