<AWT Dev> [9] Review request for 8041470: JButtons stay pressed after they have lost focus if you use the mouse wheel

[Alexander Potochkin]

Looks good to me

Thanks
alexp

> Alexander, thanks for review!
>
> Just found out that the test intermittently fails on Win (due to 
> immediate 2nd mouse wheel scroll sometimes missed).
>
> Here is the new version with updated fix (wait for the first scroll 
> event then make the second):
> http://cr.openjdk.java.net/~anashaty/8041470/webrev.02/ 
> <http://cr.openjdk.java.net/%7Eanashaty/8041470/webrev.02/>
>
> Thanks!
> Anton.
>
> On 28.05.2015 16:17, Alexander Zvegintsev wrote:
>> the fix looks good to me.
>> Thanks,
>>
>> Alexander.
>> On 05/28/2015 03:32 PM, Anton Nashatyrev wrote:
>>> Hello Alexander,
>>>
>>> On 27.05.2015 23:04, Alexander Zvegintsev wrote:
>>>> Hello Anton,
>>>>
>>>> As I can see type and wheel_mouse parameters are no longer used in 
>>>> getModifiers(),
>>>> so probably we can safely remove them.
>>>
>>> Sure, please see the new version: 
>>> http://cr.openjdk.java.net/~anashaty/8041470/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Eanashaty/8041470/webrev.01/>
>>>
>>> Thanks for review!
>>> Anton.
>>>
>>>> --
>>>> Thanks,
>>>> Alexander.
>>>> On 05/27/2015 07:37 PM, Anton Nashatyrev wrote:
>>>>> Hello,
>>>>>     could you please review the following fix:
>>>>>
>>>>> fix: http://cr.openjdk.java.net/~anashaty/8041470/webrev.00/ 
>>>>> <http://cr.openjdk.java.net/%7Eanashaty/8041470/webrev.00/>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8041470
>>>>>
>>>>>     Problem: mouseRelease not called on a component after dragging 
>>>>> outside and scrolling the wheel
>>>>>
>>>>>     Fix: correct logical typo
>>>>>
>>>>> Thanks!
>>>>> Anton.
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20150528/39e5b259/attachment.html>