<AWT Dev> Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

[Rajeev Chamyal]

Hello Avik,

 

As the test case is manual. Can you add some timeout for it.

 

Regards,

Rajeev Chamyal

 

From: Avik Niyogi 
Sent: 19 November 2015 16:36
To: Alexander Scherbatiy; Rajeev Chamyal; awt-dev at openjdk.java.net
Subject: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

 

Hi All,

 

Kindly review the fix for JDK9.

Bug: 

https://bugs.openjdk.java.net/browse/JDK-8019280

 

Webrev: 

http://cr.openjdk.java.net/~rchamyal/avik/8019280/webrev.00/

 

Issue: The OpenJDK implementation of CFileDialog for mac is inconsistent with how Apple's implementation would show the selection button when the dialog was set to choose directories.

Expected correct caption on the selection button should be " Choose " , not " Open " according to Mac OSX UI guidelines.

 

Cause: Incorrect implementation within CFileDialog.m

 

Fix:Added logic to setPrompt when opening a directory selection File Dialog

 

With Regards,

Avik Niyogi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20151120/c8ad0f45/attachment.html>