<AWT Dev> Review request for 8060137: Removing Text from TextField / TextArea is not possible after typing

[Semyon Sadetsky]

Hi Ambarish,

Didn't notice that was your fix, sorry...

One small issue: text = (t != null) ? t : ""; should be set even if peer 
doesn't exist.

--Semyon

On 11/20/2015 2:49 PM, Ambarish Rapte wrote:
>
> Hi ,
>
> Updating the patch to use /(peer != null)  { } / instead of /(peer == 
> null) retrun;/
>
> Please take a look//
>
> /http://cr.openjdk.java.net/~arapte/8060137/webrev.02/ 
> <http://cr.openjdk.java.net/%7Earapte/8060137/webrev.02/>/
>
> //
>
> //
>
> Many Thanks,
>
> Ambarish
>
> //
>
> *From:*Ambarish Rapte
> *Sent:* Thursday, November 19, 2015 9:19 PM
> *To:* Semyon Sadetsky; Prasanta Sadhukhan; awt-dev at openjdk.java.net
> *Subject:* RE: Review request for 8060137: Removing Text from 
> TextField / TextArea is not possible after typing
>
> Hi Semyon,
>
> Please review the updated patch as per the review comments,
>
> http://cr.openjdk.java.net/~arapte/8060137/webrev.01/ 
> <http://cr.openjdk.java.net/%7Earapte/8060137/webrev.01/>
>
> Many Thanks
>
> Ambarish
>
> *From:*Semyon Sadetsky
> *Sent:* Thursday, November 19, 2015 2:54 PM
> *To:* Ambarish Rapte; Prasanta Sadhukhan; awt-dev at openjdk.java.net 
> <mailto:awt-dev at openjdk.java.net>
> *Subject:* Re: Review request for 8060137: Removing Text from 
> TextField / TextArea is not possible after typing
>
> Hi Prasanta,
>
> Could you rework the fix a bit?
> When peer != null is false there is no need to continue the method 
> execution. And then second peer is null test is not needed.
>
> --Semyon
>
> On 11/16/2015 1:24 PM, Ambarish Rapte wrote:
>
>     Dear All,
>
>                     Please review the fix for JDK9,
>
>                     Bug: https://bugs.openjdk.java.net/browse/JDK-8060137
>
>                     Webrev:
>     http://cr.openjdk.java.net/~arapte/8060137/webrev.00/
>     <http://cr.openjdk.java.net/%7Earapte/8060137/webrev.00/>
>
>     Issue:
>
>     1.Type any character in /TextArea/ or /TextField/
>
>     2.Call /setText(null)/
>
>     ðThe text in /TextArea/ or /TextField/ does not get set to null.
>
>     Cause:
>
>     /TextComponent::setText()/, verifies /TextComponent::text/
>     variable for null value in /TextComponent::setText()/.
>
>                     But text is a java variable which may not have
>     latest value of actual at peer side.
>
>     Fix:
>
>                     Fetch the latest value from /peer.getText(),/
>     before validating for null value.
>
>                     Also updated tests for /TextArea/ & /TextField/
>     with the patch.
>
>     Many Thanks,
>
>     Ambarish
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20151120/83803784/attachment-0001.html>