<AWT Dev> Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

[Avik Niyogi]

Hi All,

Please find below the webrev with inputs from comments.
http://cr.openjdk.java.net/~aniyogi/8019280/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8019280/webrev.01/>
With Regards,
Avik Niyogi


> On 23-Nov-2015, at 2:54 pm, Ambarish Rapte <ambarish.rapte at oracle.com> wrote:
> 
> Hi Avik,
>                 As this is an awt fix, Please write the test using awt components.
>  
> Many Thanks,
> Ambarish
>  
> From: Avik Niyogi 
> Sent: Monday, November 23, 2015 12:04 PM
> To: Ambarish Rajeshwar Rapte; Semyon Sadetsky; awt-dev at openjdk.java.net
> Subject: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "
>  
> Hi All,
>  
> Kindly review the fix for JDK9.
> Bug: 
> https://bugs.openjdk.java.net/browse/JDK-8019280 <https://bugs.openjdk.java.net/browse/JDK-8019280>
>  
> Webrev: 
> http://cr.openjdk.java.net/~aniyogi/8019280/webrev.00/ <http://cr.openjdk.java.net/~aniyogi/8019280/webrev.00/>
>  
> Issue: The OpenJDK implementation of CFileDialog for mac is inconsistent with how Apple's implementation would show the selection button when the dialog was set to choose directories.
> Expected correct caption on the selection button should be " Choose " , not " Open " according to Mac OSX UI guidelines.
>  
> Cause: Incorrect implementation within CFileDialog.m
>  
> Fix:Added logic to setPrompt when opening a directory selection File Dialog
>  
> With Regards,
> Avik Niyogi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20151123/c0e51e97/attachment.html>