<AWT Dev> Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest in MacOSX
Manajit Halder
manajit.halder at oracle.com
Wed Nov 25 12:22:11 UTC 2015
Hi Semyon,
Thank you for the comment. I have changed Logger with System.err.println.
Please review the changes in the webrev.01:
http://cr.openjdk.java.net/~aniyogi/manajit/8132766/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/manajit/8132766/webrev.01/>
Regards,
Manajit
> On 25-Nov-2015, at 1:22 pm, Semyon Sadetsky <semyon.sadetsky at oracle.com> wrote:
>
> Hi Manajit,
>
> Why do you use Logger for output? Potentially Logger can be configured to redirect or hide output.
> Are you sure that it will be jprt compatible?
> I afraid that jprt team expects that System.out/err are only used in tests, so we may miss the Logger output in the test report.
>
> --Semyon
>
>
> On 11/23/2015 2:38 PM, Manajit Halder wrote:
>> Hi All,
>>
>> Kindly review the fix for JDK9.
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8132766 <https://bugs.openjdk.java.net/browse/JDK-8019280>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rchamyal/manajit/8132766/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/manajit/8132766/webrev.00/>
>>
>> Issue: Unable to determine title component. MetalLookAndFeel was not getting set.
>>
>> Cause: setDefaultLookAndFeelDecorated(true) was not setting the look and feel to MetalLookAndFeel.
>>
>> Fix: Set the look and feel to MetalLookAndFeel using setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
>> Modified the code as per the comment given in mail <http://mail.openjdk.java.net/pipermail/awt-dev/2015-August/009858.html>http://mail.openjdk.java.net/pipermail/awt-dev/2015-August/009858.html <http://mail.openjdk.java.net/pipermail/awt-dev/2015-August/009858.html>
>> Reformatted the code to get rid of Applet and made it more modular.
>>
>> Regards,
>> Manajit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20151125/fd5d2922/attachment.html>
More information about the awt-dev
mailing list