<AWT Dev> <Awt Dev> [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

[Semyon Sadetsky]

Hi Yuri,

As far as I know we do not support Gnome3 on other platforms.

--Semyon

On 11/27/2015 5:26 PM, Yuri Nesterenko wrote:
> Hi Semyon,
>
> it's OK for OEL 7 but wouldn't the tests fail for
> any other system with Gnome 3?
>
> -yan
>
> On 11/25/2015 04:29 PM, Sergey Bylokhov wrote:
>> Looks fine.
>>
>> On 25.11.15 11:18, Semyon Sadetsky wrote:
>>> On 11/12/2015 2:02 AM, Sergey Bylokhov wrote:
>>>> Isn't this is a typo in the MouseMovedTest.java? :
>>>>   42         if (SystemTray.isSupported()) {
>>>>   43             return;
>>>>   44         }
>>> Yes it is a mistake. Thanks.
>>> The updated webrev:
>>> http://cr.openjdk.java.net/~ssadetsky/8081457/webrev.02/
>>>>
>>>> Please take a look to the similar issue: JDK-8117886
>>> JDK-8117886 requires a separate investigation.
>>>>
>>>> On 06.11.15 16:07, Alexander Scherbatiy wrote:
>>>>>
>>>>>    The fix looks good to me.
>>>>>
>>>>>    Thanks,
>>>>>    Alexandr.
>>>>>
>>>>> On 10/28/2015 4:05 PM, Alexander Zvegintsev wrote:
>>>>>> The fix looks good to me.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Alexander.
>>>>>>
>>>>>> On 10/28/2015 03:01 PM, Semyon Sadetsky wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 10/14/2015 3:50 PM, Alexander Zvegintsev wrote:
>>>>>>>> Hi Semyon,
>>>>>>>>
>>>>>>>> As I can see there are a lot similar checks in tests for OEL7,
>>>>>>>> ideally it should be checked against gnome-shell(probably from
>>>>>>>> DESKTOP_SESSION env variable, or check for running gnome-shell
>>>>>>>> process), but I am OK with the current check. Could you please
>>>>>>>> extract this check to some helper method? It would be helpful, 
>>>>>>>> if we
>>>>>>>> will change this check in future.
>>>>>>> I have introduced isOel() method for the check :
>>>>>>> http://cr.openjdk.java.net/~ssadetsky/8081457/webrev.01/.
>>>>>>> gnome-shell is a common session name for both gnome2 and gnome3. So
>>>>>>> I've left the same check.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Alexander.
>>>>>>>>
>>>>>>>> On 10/13/2015 02:24 PM, Semyon Sadetsky wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> Please review fix for JDK9:
>>>>>>>>>
>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8081457
>>>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8081457/webrev.00/
>>>>>>>>>
>>>>>>>>> In OEL7 the system tray was changed a lot. It is totally 
>>>>>>>>> hidden by
>>>>>>>>> default and its tray icons only capable to receive click events.
>>>>>>>>> Mouse motion events and double click is not supported in the 
>>>>>>>>> tray.
>>>>>>>>> Also input events are sent to the embedded frame instead of the
>>>>>>>>> canvas with the icon. The mouse press event is sent to the 
>>>>>>>>> embedded
>>>>>>>>> frame only after button is released.
>>>>>>>>> In the proposed fix the mouse click listener is added to the
>>>>>>>>> embedded frame. The tray icon test suite is modified to detect 
>>>>>>>>> and
>>>>>>>>> pass OEL7 system tray.
>>>>>>>>>
>>>>>>>>> --Semyon
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>