<AWT Dev> [9] Review request for: 8086038 [macosx] No available data flavors when copying from Microsoft Word for Mac

[Sergey Bylokhov]

Looks fine.
On 05.10.15 17:44, mikhail cherkasov wrote:
> I reverted removing of "text/uri":
> http://cr.openjdk.java.net/~mcherkas/8086038/webrev.02/
> it doesn't relate to original fix, so we can go without this change.

Please file a bug to not forget this cleanup.

>
> On 10/5/2015 17:10, Sergey Bylokhov wrote:
>> On 01.10.15 17:22, mikhail cherkasov wrote:
>>> On 9/30/2015 18:48, Sergey Bylokhov wrote:
>>>> Hi, Mikhail.
>>>> Why you have removed "text/uri" from the flavormap.properties?
>>> http://cr.openjdk.java.net/~mcherkas/8086038/webrev.01/src/java.datatransfer/macosx/classes/sun/datatransfer/resources/flavormap.properties.frames.html
>>>
>>>
>>> according description in flavormap.properties, file has the following
>>> format:
>>> <native>=<MIME type>,<MIME type>, ...
>>> but "text/uri" doesn't correspond to any native type, looks like it was
>>> added by mistake.
>>
>> It was added as part of JDK-4899516 for unix. To remove it, we need to
>> check, that the bug was not reintroduced in case of mac(probably in
>> interaction with some x11 apps on mac?)
>>
>>
>>> I haven't noticed a difference after removing it and running tests.
>>> But if you think that removing that line can make problems, I'll revert
>>> this change. Anyway, it doesn't relate with
>>> the original problem.
>>>
>>>> Please format the code in CDataTransferer.m in the same way as other
>>>> lines.
>>> fixed: http://cr.openjdk.java.net/~mcherkas/8086038/webrev.01/
>>>>
>>>> On 30.09.15 14:42, mikhail cherkasov wrote:
>>>>> Hi there,
>>>>>
>>>>> Please review a fix for JDK9:
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8086038
>>>>> webrev: http://cr.openjdk.java.net/~mcherkas/8086038/webrev.00/
>>>>>
>>>>> MS Word provides pictures in PICT format
>>>>> https://en.wikipedia.org/wiki/PICT
>>>>> we don't support it and doesn't support any data flavor for it.
>>>>> However Apples java 6 provides support for it, it returns image as
>>>>> byte
>>>>> stream.
>>>>> I added the same support too for backward compatibility.
>>>>>
>>>>> Thanks,
>>>>> Mikhail.
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.