<AWT Dev> Review Request for 8055197: TextField deletes multiline strings

Ambarish Rapte ambarish.rapte at oracle.com
Wed Oct 14 16:44:13 UTC 2015


Dear All,

    Please review the patch for jdk9.
    Bug: https://bugs.openjdk.java.net/browse/JDK-8055197
    Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/8055197/webrev.00/


Issue:
    - If text containing new line character is set to TextField, Text after new line character was terminated.
    - Issue occurs only on windows.

Cause:
    - For windows new line character is   ‘\r\n’.
    - For windows code this new line character was not replaced by space character.
    - Other platforms replace the EOL character by space character.

Fix:
    - Added code to TextComponent.java to remove EOL on java side before passing to peer.
      => Added a private method replaceEOL() , which replaces EOL by space.
      => removeEOL will be called by newly added TextComponent construcotr and setText()

    - The text variable on in TextComponent.java & on string displayed on native side will be same.



Many Thanks,
Ambarish


More information about the awt-dev mailing list