<AWT Dev> [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

[Sergey Bylokhov]

looks fine.

On 08.10.15 11:19, Renjith Alexander wrote:
> Hi All,
>
> I still need two approvals for this. Could somebody please review this?
>
> Regards,
> Renjith.
>
> -----Original Message-----
> From: Renjith Alexander
> Sent: Monday, October 05, 2015 3:13 PM
> To: Yuri Nesterenko; awt-dev at openjdk.java.net
> Subject: Re: <AWT Dev> [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw
>
> Hi All,
>
> Please find the updated webrev at: http://cr.openjdk.java.net/~pchopra/8136592/webrev.01/
>
> Regards,
> Renjith.
>
> -----Original Message-----
> From: Yuri Nesterenko
> Sent: Wednesday, September 30, 2015 5:20 PM
> To: Renjith Alexander; awt-dev at openjdk.java.net
> Subject: Re: <AWT Dev> [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw
>
> Looks good but I think you should
> (1) provide in the copyright notices a year of the actual test creation (see how it is done in the updated old tests);
> (2) provide a copyright notice in the html as well.
>
> I tried the multiscreen test on my setup, it worked well with both jdk9 and jigsaw build.
>
> -yan
>
>
> On 09/29/2015 11:56 AM, Renjith Alexander wrote:
>> Hi all,
>>
>> Please review the fix for the bug:  JDK-8136592  [TEST_BUG] Fix 2
>> platform-specific closed regtests for jigsaw
>>
>> BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8136592  *
>>
>>
>>
>> The webrev is:http://cr.openjdk.java.net/~pchopra/8136592/webrev.00/
>>
>>
>>
>> These tests are being moved from closed to open. One round of review has been finished for the changes for these tests in crucible.
>>
>> --
>>
>> Regards,
>>
>> Renjith Alexander
>>
>


-- 
Best regards, Sergey.