<AWT Dev> <Awt Dev> [9] Review Request for 8134732: [TEST_BUG] Test java/awt/applet/Applet/AppletFlipBuffer.java fails on Windows with AWTException
Semyon Sadetsky
semyon.sadetsky at oracle.com
Fri Sep 4 14:42:51 UTC 2015
Yes, I thought about that. But flip buffer is potentially allowed to
throw other exceptions caused by the platform.
Wouldn't it be excessive to introduce such unspecified expectation?
On 9/4/2015 5:01 PM, Sergey Bylokhov wrote:
> On 04.09.15 15:12, Semyon Sadetsky wrote:
>> The original bug was about ClastCastException.
>
> Then probably catch AWTException which is only expected from
> createBufferStrategy?. this will cover old and new bug.
>
>> With the option the test will check nothing if buffering is not
>> supported on the test server.
>>
>> On 9/4/2015 2:40 PM, Sergey Bylokhov wrote:
>>> Hi, Semyon.
>>> Is it really necessary to catch ClassCastException? Can you try to
>>> test this functionality via -Dswing.bufferPerWindow. When this option
>>> is passed the backbuffer should be created automatically if supported.
>>>
>>> On 04.09.15 14:03, Semyon Sadetsky wrote:
>>>> Hello,
>>>>
>>>> Please review fix for JDK9:
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8134732
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8134732/webrev.00/
>>>>
>>>> It's a test bug: when the flip buffer is not available on the platform
>>>> its creation attempt causes exception.
>>>> Solution: ignore the exception.
>>>>
>>>> --Semyon
>>>
>>>
>>
>
>
More information about the awt-dev
mailing list