<AWT Dev> [9] Review request for 8134917 [macosx] JOptionPane doesn't receive mouse events when opened from a drop event

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Sep 24 13:09:52 UTC 2015


On 24.09.15 15:47, Alexander Scherbatiy wrote:
> On 9/24/2015 3:28 PM, Sergey Bylokhov wrote:
>> I wonder why this code actually fixed the previous problem? because
>> NSApplicationDefined used as a mask did not cover the
>> NSApplicationDefinedMask.
>      Because NSApplicationAWT overrides - sendEvent: method end filters
> NSApplicationDefined events out there.

Right, it overrides the sendEvent and for some 
subtype="ExecuteBlockEvent" it tries to call a block. It means that if 
LWCToolkit.nextEventMatchingMask gets an event which is related to a 
deallocation it will later call release(which is inside the block) in 
the sendEvent. And the previous fix was an attempt to eliminate this 
situation of deallocation inside the nested loop.

>
>      Thanks,
>      Alexandr.
>
>>
>> On 24.09.15 14:23, Alexander Scherbatiy wrote:
>>>    The fix corrects the typo introducing by the fix  JDK-8068886 that
>>> NSApplicationDefined constant is used instead of the corresponding mask
>>> for events filtering.
>>
>>
>


-- 
Best regards, Sergey.


More information about the awt-dev mailing list