<AWT Dev> [9] Review request for 8132706 [macosx] Toolkit.getImage() throws NPE for null URL

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Apr 15 18:10:15 UTC 2016


On 15/04/16 20:30, Sergey Bylokhov wrote:
> How the object of URLImageSource(null) will be useful? I guess we will 
> get some unspecified NPE exceptions if will try to call its methods?
   I know nothing about the URLImageSource(null) usefulness but 
ImageFetcher swallows the NPE during the image loading in the 
fetchloop() method:
-------
             try {
                 src.doFetch();
             } catch (Exception e) {
                 System.err.println("Uncaught error fetching image:");
                 e.printStackTrace();
             }
-------

   Thanks,
   Alexandr.
>
> On 15.04.16 18:02, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>>    bug: https://bugs.openjdk.java.net/browse/JDK-8132706
>>    webrev: http://cr.openjdk.java.net/~alexsch/8132706/webrev.00
>>
>>    The fix makes the Toolkit.getDefaultToolkit().getImage(URL) return a
>> ToolkitImage based on URLImageSource with null url as it was before the
>> fix JDK-8011059.
>>
>>    Thanks,
>>    Alexandr.
>
>



More information about the awt-dev mailing list