<AWT Dev> Review request for 6384991: TrayIcon ActionListener called at wrong time

[Rajeev Chamyal]

Looks good to me.

 

Regards,

Rajeev Chamyal

 

From: Ambarish Rapte 
Sent: 28 April 2016 22:26
To: Prasanta Sadhukhan; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> Review request for 6384991: TrayIcon ActionListener called at wrong time

 

Hi Prasanta,

Thanks for the review

I have updated the test case as per the review comments.

Also updated test case with few more scenarios & Os specific conditions.

 

Please review the updated webrev.01,

http://cr.openjdk.java.net/~arapte/6384991/webrev.01/

 

 

Regards,

Ambarish

 

From: prasanta sadhukhan 
Sent: Tuesday, April 19, 2016 11:25 AM
To: Ambarish Rapte; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Cc: Sergey Bylokhov; Semyon Sadetsky
Subject: Re: <AWT Dev> Review request for 6384991: TrayIcon ActionListener called at wrong time

 

Hi Ambarish,

Fix looks ok to me.
Regarding test, the copyright should be changed to 2016. Also, the initial bugid is missing, since you added bugid can you probably add the initial bugid too?
Please change the wildcard imports to specific imports.
Did you test in oel too? The test is skipped for oel if double click is done on systray but now you are supporting single-click so I guess we should remove the skipping and test in oel, right?

Regards
Prasanta

On 4/19/2016 10:51 AM, Ambarish Rapte wrote:

Hi, 

Gentle reminder for review.

 

Regards,

Ambarish

 

From: Ambarish Rapte 
Sent: Tuesday, April 12, 2016 10:03 AM
To: Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: <AWT Dev> Review request for 6384991: TrayIcon ActionListener called at wrong time

 

Hi All,

                Please review the fix for JDK9,

                Webrev: http://cr.openjdk.java.net/~arapte/6384991/webrev.00/

                Bug: https://bugs.openjdk.java.net/browse/JDK-6384991

 

Issue:

                On Unix platform, System TrayIcon react on single click.

                But Action Listener was called on double click similar to windows.

 

Fix:

                Changed to generate ActionEvent on single click for unix platform.

 

Verification:

                Modified existing test to test this fix.

                No other regression or JCK test fail due to this fix.

 

 

Regards,

Ambarish

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160429/2702a245/attachment-0001.html>