<AWT Dev> <AWT dev>[9] Push request for 8151136: [macosx] According to the description, the case is failed

[Manajit Halder]

Hi Sergey,

I will check the problem and update you. 

Thanks,
Manajit

> On 28-Apr-2016, at 7:51 pm, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hi, Manajit.
> It seems that some tests fails after this fix, for example:
> javax/swing/JPopupMenu/6827786/bug6827786.java
> 
> please check the problem.
> 
> On 27.04.16 12:15, Manajit Halder wrote:
>> Hi Semyon,
>> 
>> Rajeev is facing some issues with his ubuntu machine. So could you
>> please commit this change.
>> 
>> Regards,
>> Manajit
>> 
>>> On 27-Apr-2016, at 11:54 am, Manajit Halder <manajit.halder at oracle.com <mailto:manajit.halder at oracle.com>
>>> <mailto:manajit.halder at oracle.com <mailto:manajit.halder at oracle.com>>> wrote:
>>> 
>>> Hi Rajeev,
>>> 
>>> Could you please push the patch to JDK9 with the following details:
>>> 
>>> http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/ <http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/>
>>> 
>>> 8151136: [macosx] According to the description, the case is failed
>>> Reviewed-by: ssadetsky, aniyogi
>>> username: mhalder
>>> 
>>> Regards,
>>> Manajit
>>> 
>>>> On 26-Apr-2016, at 4:14 pm, Avik Niyogi <avik.niyogi at oracle.com <mailto:avik.niyogi at oracle.com>
>>>> <mailto:avik.niyogi at oracle.com <mailto:avik.niyogi at oracle.com>>> wrote:
>>>> 
>>>> Hi Manajit,
>>>> 
>>>> This fix looks good to me.
>>>> 
>>>> With Regards,
>>>> Avik Niyogi
>>>> 
>>>>> On 25-Apr-2016, at 5:11 pm, Semyon Sadetsky
>>>>> <semyon.sadetsky at oracle.com <mailto:semyon.sadetsky at oracle.com> <mailto:semyon.sadetsky at oracle.com <mailto:semyon.sadetsky at oracle.com>>> wrote:
>>>>> 
>>>>> Hi Manajit,
>>>>> 
>>>>> Thank you for the exhaustive explanation. Then I'd suggest to file a
>>>>> bug to add VK_ALT_GRAPH mapping on Windows and OS X.
>>>>> 
>>>>> The fix looks good to me.
>>>>> 
>>>>> --Semyon
>>>>> 
>>>>> On 4/25/2016 2:26 PM, Manajit Halder wrote:
>>>>>> Hi Semyon,
>>>>>> 
>>>>>> On Mac OS X and Windows:
>>>>>> robot.keyPress(KeyEvent.VK_ALT_GRAPH) is possible but VK_ALT_GRAPH
>>>>>> is not mapped in native platform code.
>>>>>> To automate the test case we need to map java key VK_ALT_GRAPH to
>>>>>> OS X equivalent kVK_RightOption (right option key)
>>>>>> in the native OS X code and right Alt key on Windows.
>>>>>> 
>>>>>> On Linux(Ubuntu):
>>>>>> Alt graph is configurable on Linux. By default the Alt graph key is
>>>>>> undefined in System Settings and has to be defined by the user.
>>>>>> Therefore the test case can’t be automated since it is not possible
>>>>>> to automate the test case on Linux. If we still want to automate
>>>>>> the test case then we have to write separate test cases for Linux
>>>>>> (manual) and for Mac and Windows (automated).
>>>>>> 
>>>>>> Please provide your suggestion.
>>>>>> 
>>>>>> Regards,
>>>>>> Manajit
>>>>>> 
>>>>>> 
>>>>>>> On 20-Apr-2016, at 9:54 pm, Semyon Sadetsky
>>>>>>> <semyon.sadetsky at oracle.com <mailto:semyon.sadetsky at oracle.com> <mailto:semyon.sadetsky at oracle.com <mailto:semyon.sadetsky at oracle.com>>>
>>>>>>> wrote:
>>>>>>> 
>>>>>>> Hi Manajit,
>>>>>>> 
>>>>>>> Why robot.keyPress(KeyEvent.VK_ALT_GRAPH) cannot be used to press
>>>>>>> the right Alt?
>>>>>>> 
>>>>>>> --Semyon
>>>>>>> 
>>>>>>> On 4/20/2016 3:16 PM, Manajit Halder wrote:
>>>>>>>> Hi Semyon,
>>>>>>>> 
>>>>>>>> Thank you for the review comment.
>>>>>>>> The test can’t be automated because of the following reasons:
>>>>>>>> 
>>>>>>>> On Mac OS X and Windows:
>>>>>>>> There is no key code for the right ALT button (no right key codes
>>>>>>>> for ALT, SHIFT, COMMAND).robot.keyPress(KeyEvent.VK_ALT) will
>>>>>>>> press the left ALT key.
>>>>>>>> It is not possible to press the right ALT key using robot.
>>>>>>>> Hence Alt-Gr modifier won’t be set using robot.
>>>>>>>> 
>>>>>>>> On Linux:
>>>>>>>> The Alt graph is configurable.
>>>>>>>> 
>>>>>>>> Regards,
>>>>>>>> Manajit
>>>>>>>> 
>>>>>>>> 
>>>>>>>>> On 12-Apr-2016, at 9:07 pm, Semyon Sadetsky
>>>>>>>>> <semyon.sadetsky at oracle.com <mailto:semyon.sadetsky at oracle.com> <mailto:semyon.sadetsky at oracle.com <mailto:semyon.sadetsky at oracle.com>>>
>>>>>>>>> wrote:
>>>>>>>>> 
>>>>>>>>> Hi Manajit,
>>>>>>>>> 
>>>>>>>>> The fix itself is OK.
>>>>>>>>> Why the test cannot be automated?
>>>>>>>>> 
>>>>>>>>> --Semyon
>>>>>>>>> 
>>>>>>>>> On 4/12/2016 1:46 PM, Manajit Halder wrote:
>>>>>>>>>> Hi All,
>>>>>>>>>> 
>>>>>>>>>> Gentle remainder. Please review the changes.
>>>>>>>>>> 
>>>>>>>>>> Thanks,
>>>>>>>>>> Manajit
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>>> On 07-Apr-2016, at 1:48 pm, Manajit Halder
>>>>>>>>>>> <<mailto:manajit.halder at oracle.com <mailto:manajit.halder at oracle.com>>manajit.halder at oracle.com <mailto:manajit.halder at oracle.com>>
>>>>>>>>>>> wrote:
>>>>>>>>>>> 
>>>>>>>>>>> Hi All,
>>>>>>>>>>> 
>>>>>>>>>>> Kindly review the fix for JDK9.
>>>>>>>>>>> 
>>>>>>>>>>> *Bug*:
>>>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8151136 <https://bugs.openjdk.java.net/browse/JDK-8151136>
>>>>>>>>>>> _
>>>>>>>>>>> _
>>>>>>>>>>> *Webrev*:
>>>>>>>>>>> http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/
>>>>>>>>>>> 
>>>>>>>>>>> *Issue: *
>>>>>>>>>>> [macosx] According to the description,the case is failed
>>>>>>>>>>> (AltGraph key is not supported on OS X).
>>>>>>>>>>> 
>>>>>>>>>>> *Cause: *
>>>>>>>>>>> On OS X AltGraph functionality was not implemented.
>>>>>>>>>>> 
>>>>>>>>>>> *Information on AltGraph Key on OS X:*
>>>>>>>>>>> On OS X there is no key defined for AltGraph on the Keyboard.
>>>>>>>>>>> As per wikipedia link
>>>>>>>>>>> https://en.wikipedia.org/wiki/AltGr_key Option key has
>>>>>>>>>>> function similar to the AltGr key. But Option is also Alt key
>>>>>>>>>>> on OS X.
>>>>>>>>>>> 
>>>>>>>>>>> *Fix: *
>>>>>>>>>>> Right Option key is defined to behave as AltGraph key on OS X.
>>>>>>>>>>> AltGraph functionality is added for left key.
>>>>>>>>>>> 
>>>>>>>>>>> Regards,
>>>>>>>>>>> Manajit
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> 
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160429/aa0b8fbc/attachment.html>