<AWT Dev> [9] Review request for 8017112 JTabbedPane components have inconsistent accessibility tree

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Apr 29 16:42:33 UTC 2016


   Hello,

   Cold you review the updated fix: 
http://cr.openjdk.java.net/~alexsch/8017112/webrev.01

   The (this instanceof Accessible) is removed from the fix.

   Thanks,
   Alexandr.

On 29/04/16 01:37, Sergey Bylokhov wrote:
> Hi, Alexander.
> Is the "instance of" check is necessary at the beginning of the method?
> Usually we use the "instance of" to get AccessibleContext in code like 
> this:
> AccessibleContext accContext = ((Accessible)this).getAccessibleContext();
>
> But it seems we have not the cast here, or it is necessary for some 
> reason?
>
> On 28.04.16 22:39, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>>    bug: https://bugs.openjdk.java.net/browse/JDK-8017112
>>    webrev: http://cr.openjdk.java.net/~alexsch/8017112/webrev.00
>>
>>
>>    Component.getAccessibleIndexInParent() takes parent from components
>> hierarchy which can be different from the accessibility tree hierarchy.
>> The method is updated to use the right parent.
>>
>>
>>    Thanks,
>>    Alexandr.
>>
>
>



More information about the awt-dev mailing list