<AWT Dev> [9] Review Request: 8148109 [SWT] Provide a supported mechanism to use EmbeddedFrame

[Sergey Bylokhov]

On 02.08.16 18:43, Philip Race wrote:
> OK .. I think somewhere we saw SWT code doing this on windows,
> although I may be confusing it with something else. It seemed like
> it was a workaround for a JDK bug.

It seems in the new version of SWT_AWT.java on windows it will be removed:
https://git.eclipse.org/r/#/c/75211/2/bundles/org.eclipse.swt/Eclipse+SWT+AWT/win32/org/eclipse/swt/awt/SWT_AWT.java

I will track the changed in swt to handle any possible bugs.

>
> So overall this seems fine now.
>
> Up to you whether you deal with a note on hi-dpi in this change
> or separately since as you point out it applies to extant methods too ..
>
> -phil.
>
> On 8/2/16, 8:36 AM, Sergey Bylokhov wrote:
>> On 02.08.16 18:28, Philip Race wrote:
>>> Ok, so when you wrote :
>>>  - On OSX validateWithBounds() intentionally was changed to
>>> setBoundsPrivate() as on other platforms.
>>>
>>> where should I see that change ?
>>
>> In the CViewEmbeddedFrame we have two methods setBoundsPrivate() and
>> validateWithBounds(). Currently on OSX the SWT library use
>> CViewEmbeddedFrame.validateWithBounds() (this method also validate the
>> frame and make it visible). In the jawt api I use setBoundsPrivate()
>> and skip validateWithBounds, so validate+setVisible should be called
>> by the client of jawt API. (like on other platforms win/lin). I am
>> actually not sure that it is necessary to call validate here.
>>


-- 
Best regards, Sergey.