<AWT Dev> Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

[Prem Balakrishnan]

Hi Alexandr and Sergey,

 

Please review the updated patch.

http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.01/

>>"It is a little bit strange bug, because VolatileImage should handle this scale internally, and create double sized surface when necessary".-Sergey

Yes as you mentioned Volatile Image is getting scaled internally. Thanks for the feedback.

 

Cause: In  VIOptWindowPainter::updateWindowAccel(psdops, w, h) call, width and height were passed without scaling,
which was creating a bitmap of specified width and height, hence the output was clipped.
 
 
Regards,
Prem

 

 

From: Alexandr Scherbatiy 
Sent: Thursday, August 04, 2016 6:23 PM
To: Prem Balakrishnan; Rajeev Chamyal; awt-dev at openjdk.java.net; Sergey Bylokhov
Subject: Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

 

On 8/3/2016 10:04 AM, Prem Balakrishnan wrote:

Hi,

Please review fix for JDK9,

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8144735  

 

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8144735/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.00/ 

 

 

Issue:

javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails 

 

Cause:

While creating Transparent VolatileImage, width and height was NOT hidpi scaled.

 

Fix: VolatileImage width and height are scaled.


   I believe this is an issue in AWT and needs to be discussed on awt-dev alias.

   Should the backbuffer width and height be also scaled for the BIWindowPainter?

  Thanks,
  Alexandr.
 

 

Thanks,

Prem

 

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160812/8654469f/attachment-0001.html>