<AWT Dev> Review request for 8160570: [mac] modal dialog can skip the activation/focus events

[Anton Tarasov]

On 8/30/2016 7:05 PM, Semyon Sadetsky wrote:
>
>
> On 8/30/2016 6:18 PM, Anton Tarasov wrote:
>> Hi Semyon,
>>
>> On 8/29/2016 9:08 PM, Semyon Sadetsky wrote:
>>> On 8/29/2016 8:29 PM, Anton Tarasov wrote:
>>>
>>>> Hi Semyon,
>>>>
>>>> As I wrote in JIRA, the problem is caused by the fact that a native 
>>>> window (for a modal dialog) is shown before the peer starts to 
>>>> show. (This seems strange, and you can investigate the reason, I’m 
>>>> not aware)
>>> Maybe because NSWindow.orderFrontRegardless() is called? Why it is 
>>> called on that moment and why the "Regardless" version is used?
>>
>> Well, I suggest a one-line fix, harmless from my point of view. And 
>> I'm pointing to a problematic spot alongside. I'd love to know why 
>> modal dialogs are shown that way, but I'm afraid there was a hidden 
>> reason. May be it's gone, please investigate it (sorry, I don't have 
>> enough resources to do that at the moment). If you don't mind I'd 
>> push the fix in its current version...
> Okay, Anton. It seems nobody of has time to investigate this. Couldn't 
> you, please, create a new JIRA ticket and describe the problem in it 
> for further investigation. Maybe you will be able to come back to this 
> issue in future releases.

Sure, I filed it: https://bugs.openjdk.java.net/browse/JDK-8165157

Thanks,
Anton.

>
> --Semyon
>>
>> Regards,
>> Anton.
>>
>>>
>>> --Semyon
>>>> The problem is thus specific to OSX.
>>>>
>>>> Regards,
>>>> Anton.
>>>>
>>>>> On 29 Aug 2016, at 19:30, Semyon Sadetsky 
>>>>> <semyon.sadetsky at oracle.com> wrote:
>>>>>
>>>>> Hi Anton,
>>>>>
>>>>> is it really OS X only problem? It seems on other platforms the 
>>>>> peer focusability is updated in the same way.
>>>>>
>>>>> --Semyon
>>>>>
>>>>>
>>>>> On 6/29/2016 9:04 PM, Anton Tarasov wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review the fix:
>>>>>>
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8160570
>>>>>> webrev: http://cr.openjdk.java.net/~ant/JDK-8160570/webrev.0 
>>>>>> <http://cr.openjdk.java.net/%7Eant/JDK-8160570/webrev.0>
>>>>>>
>>>>>> The problem is that a modal dialog can skip the activation/focus 
>>>>>> events on OSX.
>>>>>> The fix is to cache the focusability state of the Window peer 
>>>>>> earlier, in its ctor.
>>>>>> Please find more details in JIRA.
>>>>>>
>>>>>> Thanks,
>>>>>> Anton.
>>>
>>
>