<AWT Dev> [9] Review request for 8154314: [TEST_BUG] java/awt/datatransfer/DragImage/MultiResolutionDragImageTest.java

Sergey Bylokhov sergey.bylokhov at oracle.com
Tue Dec 20 15:02:58 UTC 2016


Looks fine, thanks.

> 
> webrev updated: http://cr.openjdk.java.net/~avstepan/8154314/webrev.03 <http://cr.openjdk.java.net/%7Eavstepan/8154314/webrev.03>
> 
> Removed unused module declaration
> 
> 
> On 20.12.2016 16:13, Sergey Bylokhov wrote:
>>> webrev updated: http://cr.openjdk.java.net/~avstepan/8154314/webrev.02 <http://cr.openjdk.java.net/%7Eavstepan/8154314/webrev.02>
>>> 
>>> getScaleFactor() code is now directly used GraphicsEnviroinment code to get scale factor.
>> Since the "import sun.java2d.SunGraphics2D» was removed then probably "@modules java.desktop/sun.java2d» can be removed as well?
>> 
>>> 
>>> Thanks,
>>> Maksim
>>> 
>>> 
>>> On 19.12.2016 18:47, Maksim Khramov wrote:
>>>> Hello, 
>>>> 
>>>> please review this request... 
>>>> 
>>>> Webrev: http://cr.openjdk.java.net/~avstepan/8154314/webrev.01/ <http://cr.openjdk.java.net/%7Eavstepan/8154314/webrev.01/> <http://cr.openjdk.java.net/%7Eavstepan/8154314/webrev.01/> <http://cr.openjdk.java.net/%7Eavstepan/8154314/webrev.01/> 
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8154314 <https://bugs.openjdk.java.net/browse/JDK-8154314> 
>>>> 
>>>> Test bug. Compilation of java/awt/datatransfer/DragImage/MultiResolutionDragImageTest.java still fails due removed method 
>>>> 
>>>> Thanks, 
>>>> Maksim. 
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20161220/839359ef/attachment.html>


More information about the awt-dev mailing list