<AWT Dev> <Awt Dev> [9] Review Request for 8139227: Text fields in JPopupMenu structure do not receive focus in hosted Applets

[Sergey Bylokhov]

Looks fine.

On 06.11.15 12:25, Alexander Scherbatiy wrote:
>
>    The fix looks good to me.
>
>    Thanks,
>    Alexandr.
>
> On 11/5/2015 6:23 PM, Semyon Sadetsky wrote:
>>
>>
>> On 11/5/2015 5:50 PM, Alexander Scherbatiy wrote:
>>> On 10/19/2015 2:08 PM, Semyon Sadetsky wrote:
>>>> Hello,
>>>>
>>>> Please review fix for JDK9:
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8139227
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8139227/webrev.00/
>>>>
>>>> Win32 window owner query returns the browser frame for applet's
>>>> child window because there are no any other overlapped or popup
>>>> windows on the path.  Since the browser frame is not an AWT window
>>>> the focus proxy is lost and synthetic focus doesn't work.
>>>> As a solution the AWT owner window is requested from the AWT parent
>>>> in case if AWT owner cannot be found using Windows owner.
>>>
>>>     - There is the check in the while loop for the owner to null. It
>>> seems that the initialOwner can be also null in the same way.
>> Those are unrelated values. The owner reference in the while exit
>> condition is the iterated value while the InitialOwner reference is
>> set to the method argument value which cannot be null.
>>>     - Why did the InitOwner(AwtWindow *owner) method work in the JDK
>>> 6 for the described case?
>> Because the synthetic focus in Windows was implemented after jdk6.
>>>
>>>    Thanks,
>>>    Alexandr.
>>>
>>>>
>>>> --Semyon
>>>>
>>>
>>
>


-- 
Best regards, Sergey.