<AWT Dev> Review request for 8147834: [macosx] KeyEvents for function keys F17, F18, F19 return keyCode 0

[Sergey Bylokhov]

Looks fine.

On 12.02.16 15:37, Manajit Halder wrote:
> Hi All,
>
> Kindly review the fix for JDK9.
>
> *Bug: *
> https://bugs.openjdk.java.net/browse/JDK-8147834
>
> *Webrev:*
> http://cr.openjdk.java.net/~mhalder/8147834/webrev.00
>
>
> *Issue: *
> [macosx] KeyEvents for function keys F17, F18, F19 return keyCode 0.
>
> *Fix: *
> Added the key codes for function keys F17, F18 and F19 on the MacOS X
> side. The values of the keys were referred from following file
> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h
> on MacOS X. Fix is also added for function key F20 because F20 key is
> valid in Java and MacOS X the and need to be supported on MacOS. But
> this key can’t be tested with the normal USB keyboard because it has
> function key till F19.
>
> *Justification of fix:*
> Key codes of the keys F17, F18, F19 and F20 were not added on the MacOS
> X side. Fix for key F20 is added because the key should be supported as
> per the java documentation and the key is a valid function key on MacOS X.
> *
> *
> *Testing the fix: *
> The fix was tested manually using the code present in the description.
> The automated test case is not ready. While writing the test case it was
> found that robot.keyPress is failing for function keys F13 to F19 (also
> will fail for F20). An issue is created for the same problem with jira
> id https://bugs.openjdk.java.net/browse/JDK-8149456.
>
> aAutomated test case will be provided in future after fixing issue
> https://bugs.openjdk.java.net/browse/JDK-8149456.
>
> Regards,
> Manajit


-- 
Best regards, Sergey.