<AWT Dev> Review Request for 8057574: Inconsistent behavior for setBackground (Windows/Linux)

[Prem Balakrishnan]

Hi Semyon,

 

Thanks for the review comments.

 

1.       I will add a relative test for the fix.

 

2.       The same issue is observed with Frame also,

        As the original issue is reported for dialog, fix submitted only for dialog. 

Should I combine  fix for  Dialog and Frame in the same patch?

 

Regards,

Prem

 

 

From: Semyon Sadetsky 
Sent: Monday, January 11, 2016 3:32 PM
To: Prem Balakrishnan; Ambarish Rapte; awt-dev at openjdk.java.net
Subject: Re: Review Request for 8057574: Inconsistent behavior for setBackground (Windows/Linux)

 

Hi Prem,

By default a fix requires a regression test which fails before the fix an passes after. When it is absent noreg-??? label should be set to the JIRA ticket. See http://openjdk.java.net/guide/changePlanning.html for possible noreg suffixes.
But it seems to me that reg test can be written for the issue.

In JIRA Alexander Stepanov noted that the issue takes place for Frame as well but your solution is fixing the Dialog only. Did you run the scenario with Frame?

--Semyon

On 1/4/2016 11:28 AM, Prem Balakrishnan wrote:

Hi,

Please review fix for JDK9,

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8057574 

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Earapte/prem/8057574/webrev.00/"http://cr.openjdk.java.net/~arapte/prem/8057574/webrev.00/

 

Issue:

It is Platform specific Issue - LINUX

If Child Dialog's Background color is NOT set explicitly, Child Dialog inherits Parent Dialog's Background Color.

(In Windows OS Child Dialog is NOT inheriting parent Dialog's Background Color)

 

Cause:

Default Background color for Dialog is not initialized.

 

Fix:

If Background color is not set explicitly , default Background color is set at the time of Dialog's initialization.

 

Thanks,

Prem

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160111/929ef86a/attachment.html>