<AWT Dev> Review request for 7035459: "java.lang.RuntimeException"

[Prem Balakrishnan]

Hi Ambarish,

Thanks for the review comments.

Separate bug is raised for the MAC specific behavior issue.
https://bugs.openjdk.java.net/browse/JDK-8146973 


Regards,
Prem 

-----Original Message-----
From: Ambarish Rapte 
Sent: Wednesday, January 13, 2016 11:55 AM
To: Sergey Bylokhov; Prem Balakrishnan; Semyon Sadetsky; awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> Review request for 7035459: "java.lang.RuntimeException"

Hi Prem,

	The fix is fine, solves bug on windows and unix platform.
	As we discussed the test fails on MAC due to MAC specific behavior.
	Please raise separate bug for this MAC failure.

Thanks,
Ambarish

-----Original Message-----
From: Sergey Bylokhov
Sent: Tuesday, January 12, 2016 7:45 PM
To: Prem Balakrishnan; Semyon Sadetsky; Ambarish Rapte; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> Review request for 7035459: "java.lang.RuntimeException"

Looks fine.

On 28/12/15 08:38, Prem Balakrishnan wrote:
> Hi,
>
> Please review fix for JDK9,
>
> *Bug:* https://bugs.openjdk.java.net/browse/JDK-7035459
>
> *Webrev:* http://cr.openjdk.java.net/~arapte/prem/7035459/webrev.00/
>
> *Issue:*
>
> Exception java.lang.RuntimeException: can not set focus on 
> java.awt.Button[button0,0,0,115x23,label=button for focus]
>
> *Cause:*
>
> Initial Robot action on clicking title bar of Owner frame was actually 
> minimizing the window(also button associated with it).
>
> When trying to focus on the Button associated with this window, 
> Exception was thrown
>
> *Fix:*
>
> 1.The window width was increased from 200 to 300. (to ensure click on 
> title bar was not clicking the minimize button).
>
> 2.Listeners were added after performing Robot actions, because of 
> which events were not handled properly,
>
>          hence moved the addListeners code before performing Robot action.
>
> Thanks,
>
> Prem
>


--
Best regards, Sergey.