<AWT Dev> Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

[prasanta sadhukhan]

Hi Ambarish,

This

if (textArea.getSelectedText().contentEquals("")) {
             dispose();
             throw new RuntimeException ("The robot test operations did not "
                 + "sync properly.");
         }

robot not synchronizing is not actually testing the bug. Probably you 
can combine both and just check

if (!textArea.getSelectedText().contentEquals("1234")) {
throw RuntimeException()
}

Regards
Prasanta
On 1/14/2016 2:24 PM, Ambarish Rapte wrote:
>
> Hi Prasanta,
>
> Yes, verified in windows. The fix for windows only. But the test will 
> be executed for all platforms.
>
> Selected text varies platform to platform as double clicking on word 
> might select the word with or without suffixing space character.
>
> Also I have modified the test a bit.
>
> Please take a look.
>
> http://cr.openjdk.java.net/~arapte/6180449/webrev.01/ 
> <http://cr.openjdk.java.net/%7Earapte/6180449/webrev.01/>
>
> Thanks,
>
> Ambarish
>
> *From:*prasanta sadhukhan
> *Sent:* Tuesday, January 12, 2016 4:41 PM
> *To:* Ambarish Rapte; Semyon Sadetsky; awt-dev at openjdk.java.net
> *Subject:* Re: Review request for 6180449: PIT: Text in TextArea 
> scrolls to its left one char when selecting the text from the end
>
> Look ok to me.
> Did you do the test in windows also?
> This message can be changed as it seems expected result is same for 
> all platform, right? so why to mention mac differently
>
> Expected selected text: '1234 ' and for mac '1234'"
>
> On 1/12/2016 3:34 PM, Ambarish Rapte wrote:
>
>     Hi,
>
>                     Please review the fix for JDK9.
>
>                     Bug: https://bugs.openjdk.java.net/browse/JDK-6180449
>
>                     Webrev:
>     http://cr.openjdk.java.net/~arapte/6180449/webrev.00/
>     <http://cr.openjdk.java.net/%7Earapte/6180449/webrev.00/>
>
>     Issue:
>
>                     When selecting text from right end towards left in
>     TextArea and keep scrolling beyond bounds of TextArea,
>
>                     contents of TextArea scroll beyond the bounds of
>     TextArea to left side.
>
>     Cause:
>
>                     This is a side effect of 5003402 fix.
>
>     Fix:
>
>     Altered 5003402 patch, to remove two SendMessage() calls with
>     EM_HIDESELECTION message calls.
>
>     Verification:
>
>     5003402 does not reproduce after this change in webrev.00
>
>     Verified that the existing TextArea tests work fine with this
>     patch fix with jtreg.
>
>     Test added with the patch executes & passes with ubuntu & mac.
>
>     Many Thanks,
>
>     Ambarish
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160114/24edb303/attachment.html>