<AWT Dev> [9] Review request for 8159374 : Taskbar.setIconBadge() spec omits mention of exception for ICON_BADGE_TEXT feature

[Alexandr Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 7/6/2016 3:15 PM, Alexander Zvegintsev wrote:
> http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/01/
>
> It is possible, it can be checked on the peer level only partially(as 
> long as we have API for icon badge with a String as a parameter only).
> If this is not the acceptable solution, we might consider to add 
> setIconBadge(long badge) method.
> --
> Thanks,
> Alexander.
> On 07/06/2016 10:25 AM, Alexandr Scherbatiy wrote:
>> On 7/5/2016 5:54 PM, Alexander Zvegintsev wrote:
>>>
>>> We have two cases:
>>>
>>>  1. Underlying system(Linux) supports only numbers as parameter
>>>     (adding this check will block Linux).
>>>  2. Underlying system(OS X) supports strings as parameter, but since
>>>     we can always convert a number to a string numbers are supported
>>>     too.
>>>
>>> So if system doesn't support numbers it doesn't support strings too, 
>>> thus this exception will be thrown in this case.
>>>
>>    Is it possible that on Linux using a string parameter does not 
>> throw the specified exception? Could it be checked on the peer level?
>>
>>   Thanks,
>>   Alexandr.
>>
>>>
>>> On 7/5/16 5:32 PM, Alexandr Scherbatiy wrote:
>>>> On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote:
>>>>> Hello,
>>>>>
>>>>> please review the fix
>>>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00
>>>>> for the issue
>>>>> https://bugs.openjdk.java.net/browse/JDK-8159374
>>>>   Should the  "checkFeatureSupport(Feature.ICON_BADGE_TEXT)" be 
>>>> added to the setIconBadge() method?
>>>>
>>>>   Thanks,
>>>>   Alexandr.
>>>>
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160706/f28d201f/attachment.html>