<AWT Dev> <AWT dev>[9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files from MACOSX_PORT

[Alexandr Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 7/12/2016 2:47 PM, Manajit Halder wrote:
> Hi Alexandr,
>
> Thank you for the review comments. Code is modified as per you 
> suggestion. RobotUtilities class is replaced with direct calls to 
> corresponding methods in Robot class and also Util class is used in 
> some places.
> Please review the modified code.
>
> http://cr.openjdk.java.net/~mhalder/8160266/webrev.01/ 
> <http://cr.openjdk.java.net/%7Emhalder/8160266/webrev.01/>
>
> Thanks,
> Manajit
>
>
>> On 08-Jul-2016, at 3:57 pm, Alexandr Scherbatiy 
>> <alexandr.scherbatiy at oracle.com 
>> <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>>
>>
>> Is it possible to get rid of the RobotUtilities class? Methods like 
>> RobotUtilities.pressKey(int num)/releaseKey(int num) are just direct 
>> calls to the corresponding methods in Robot.
>> Other necessary methods can be added to 
>> test/java/awt/regtesthelpers/Util.java
>>
>> Thanks,
>> Alexandr.
>>
>> On 7/7/2016 1:32 PM, Manajit Halder wrote:
>>> Hi All,
>>>
>>> Gentle remainder. Please review the fix for issue 
>>> https://bugs.openjdk.java.net/browse/JDK-8160266.
>>>
>>> Thanks,
>>> Manajit
>>>
>>>> On 24-Jun-2016, at 8:53 pm, Manajit Halder 
>>>> <manajit.halder at oracle.com <mailto:manajit.halder at oracle.com>> wrote:
>>>>
>>>> Hi Sergey,
>>>>
>>>> Kindly review the fix for JDK9.
>>>>
>>>> *Bug*:
>>>> https://bugs.openjdk.java.net/browse/JDK-8160266
>>>> _
>>>> _
>>>> *Webrev*:
>>>> http://cr.openjdk.java.net/~mhalder/8160266/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Emhalder/8160266/webrev.00/>
>>>>
>>>> *Issue: *
>>>> [macosx] NestedModalDialogTest.java and 
>>>> NestedModelessDialogTest.java tests does not run with current JDK 
>>>> codebase after taking the files from MACOSX_PORT
>>>>
>>>> *Cause: *
>>>> Both the tests were written using unit.framework.
>>>>
>>>> *Fix: *
>>>> Test files are modified to remove the dependency of junit.framework 
>>>> and related API calls. Test files were moved from MACOSX_PORT to 
>>>> the current JDK 9 codebase and added at the corresponding folder 
>>>> location:
>>>> test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
>>>> test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
>>>>
>>>> Along with the test file 3 supporting files are also moved. The 
>>>> files are:
>>>> test/java/awt/regtesthelpers/RobotUtilities.java
>>>> test/java/awt/regtesthelpers/VisibilityValidator.java
>>>> test/java/awt/regtesthelpers/Waypoint.java
>>>>
>>>>
>>>> Regards,
>>>> Manajit
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160714/5f146d8f/attachment-0001.html>