<AWT Dev> [9] Review request for 8025130: [macosx] Frame setLocationByPlatform has no effect under Mac OS X

[Semyon Sadetsky]

Thank you Dmitry. You could change it upon the push.

Still looks good to me.

--Semyon


On 6/8/2016 12:16 PM, dmitry markov wrote:
> Hi Semyon,
>
> Thank you for the review. I have updated the fix based on your 
> suggestions. Just in case the updated webrev is located at 
> http://cr.openjdk.java.net/~dmarkov/8025130/webrev.01/
>
> Thanks,
> Dmitry
> On 08/06/2016 10:44, Semyon Sadetsky wrote:
>> Hi Dmitri,
>>
>> The fix looks good to me.
>>
>> In the test please dispose frames in case of exception
>>
>> and don't forget to set the correct GPL year in AWTWindow.m.
>>
>> --Semyon
>>
>> On 6/8/2016 10:07 AM, dmitry markov wrote:
>>> Any volunteers to review the fix?
>>>
>>> Thanks in advance,
>>> Dmitry
>>> On 02/06/2016 11:18, dmitry markov wrote:
>>>> Hello,
>>>>
>>>> Could you review a fix for jdk9, please?
>>>>
>>>>     bug: https://bugs.openjdk.java.net/browse/JDK-8025130
>>>>     webrev: http://cr.openjdk.java.net/~dmarkov/8025130/webrev.00/
>>>>
>>>> Problem description:
>>>> Invocation of setLocationByPlatform() has no effect under Mac OS X, 
>>>> (i.e. the feature is not fully implemented for this platform).
>>>>
>>>> Fix:
>>>> Introduce new method nativeSetNSWindowLocationByPlatform(). It 
>>>> moves a window to 'default location' calculated by platform using 
>>>> cascadeTopLeftFromPoint function from NSWindow.
>>>> Add check of locationByPlatform flag to 
>>>> CPlatformWindow.setVisible(). If the flag is set, a window will be 
>>>> moved to 'default location'.
>>>>
>>>> Thanks,
>>>> Dmitry
>>>
>>
>