<AWT Dev> <AWT dev>[9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

[Sergey Bylokhov]

On 20.06.16 13:29, Semyon Sadetsky wrote:
>> So can you confirm that after the fix the next code will work w/o
>> exceptions?
>> http://cr.openjdk.java.net/~serb/tmp/Test.java
> Yes, for the single screen configuration.
> This test has no use for multimonitor config because display mode change
> is not supported in case of Xinerama.

The test also should pass in case of Xinerama, because it contains the 
necessary checks inside "isDisplayChangeSupported()" to skip changing 
the display modes if it is unsupported.

>> I am worried since we updated the enumDisplayModes(), but did not
>> update the getCurrentDisplayMode() which still uses the old code.

I think this case should fail.

>>
>>>>>>>>>> the list of supported modes changed and my question was: what
>>>>>>>>>> happens
>>>>>>>>>> when these modes will be passed to setDisplayMode() (of course
>>>>>>>>>> modes
>>>>>>>>>> and setDisplayMode should be from one GraphicsDevice object).
>>>>>>>>> the same as before the fix.
>>
>> Actually it seems that setDisplayMode() should not work since
>> JDK-8131752. probably someday we should change the code in
>> X11GraphicsDevice.isDisplayChangeSupported(), which skip the xinerama
>> case.
>>
>


-- 
Best regards, Sergey.