<AWT Dev> [9] Review request for 8154816: Caps Lock doesn't work as expected when using Pinyin Simplified input method

[dmitry markov]

Hi Semyon,

Thank you for review.

I guess, the applet based tests are still suitable. As far as I know 
there are many regression tests for AWT/Swing which use such approach. 
And I am not aware of any plans/activities to remove/re-write them.

Thanks,
Dmitry
On 20/06/2016 11:29, Semyon Sadetsky wrote:
> Hi Dmitry,
>
> The fix looks good.
>
> I am only not sure that an applet based test is suitable since applets 
> are deprecated.
>
> --Semyon
>
>
> On 6/17/2016 1:45 PM, dmitry markov wrote:
>> Hello,
>>
>> Could you review a fix for jdk9, please?
>>
>>     bug: https://bugs.openjdk.java.net/browse/JDK-8154816
>>     webrev: http://cr.openjdk.java.net/~dmarkov/8154816/webrev.00/
>>
>> Problem description:
>> When Pinyin Simplified input method is selected and 'Caps Lock' is 
>> on, input is switched to latin letters, but letters are entered in 
>> uppercase.
>>
>> Fix:
>> It is necessary to ignore 'Caps Lock' modifier in 
>> CPlatformResponder.handleKeyEvent() method, if Pinyin Simplified 
>> input method is selected and 'Caps Lock' is on.
>>
>> Thanks,
>> Dmitry
>