<AWT Dev> Review request for 8158616: [TEST_BUG] There is only "Fail" button on the description dialog

[Ambarish Rapte]

Hi Semyon,

                JDK-8155740, is pushed now, http://hg.openjdk.java.net/jdk9/client/jdk/rev/16a8f15abd96

                On mac Robot supports Alt-Gr key press now, hence excluding mac also.

 

                Please review the updated webrev: http://cr.openjdk.java.net/~arapte/8158616/webrev.01/

                Changes:

1.       Exclude the test for windows and mac.

2.       Using jtreg tags for exclusion instead of testlibrary.

 

Regards,

Ambarish

                

 

From: Semyon Sadetsky 
Sent: Wednesday, June 15, 2016 8:53 PM
To: Ambarish Rapte; Prasanta Sadhukhan; Sergey Bylokhov; awt-dev at openjdk.java.net
Subject: Re: Review request for 8158616: [TEST_BUG] There is only "Fail" button on the description dialog

 

 

 

On 6/15/2016 2:05 PM, Ambarish Rapte wrote:

Hi Semyon,

 

Yes, the test is automatic for windows and it is tested with the test: test/java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java

Windows robot supports Alt-Gr key press: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/80766aba7d32

Hence the test could be automated.

 

But on Linux and mac robot does not support Alt-Gr key press yet, hence the test is manual.

It seems for mac this also will fixed as JDK-8155740 is pushed, right?

--Semyon



 

Regards,

Ambarish

 

From: Semyon Sadetsky 
Sent: Wednesday, June 15, 2016 3:08 PM
To: Ambarish Rapte; Prasanta Sadhukhan; Sergey Bylokhov; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: Re: Review request for 8158616: [TEST_BUG] There is only "Fail" button on the description dialog

 

Hi Ambarish,

Does it mean that the test was automatic on Windows and manual on other OSes?

--Semyon

 

On 6/15/2016 12:13 PM, Ambarish Rapte wrote:

Hi ,

Please review the test bug fix for JDK9,

Webrev: http://cr.openjdk.java.net/~arapte/8158616/webrev.00/

Bug: https://bugs.openjdk.java.net/browse/JDK-8158616

 

 

Issue: 

Misleading description to click pass button in test steps for Windows.

But there is no pass button.

As the pass criteria is verified programmatically, there is no need of Pass button.

 

Fix:

Corrected the description &

Skipping the test execution for Windows platform, as the test is automated under Robot class.

 

Verification:

Test executes successfully on Windows, Ubunu & Mac

 

 

Regards,

Ambarish

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160624/11215849/attachment-0001.html>