<AWT Dev> [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Mar 9 16:10:00 UTC 2016



On 03/03/16 18:45, Alexander Stepanov wrote:
> Could you please review the updated version of the test?
> http://cr.openjdk.java.net/~avstepan/8150724/webrev.01
>
> Line
>  106         tabbedPane.addTab("", icon, p);
> was replaced with
>  109         tabbedPane.addTab("", p);
>  110         tabbedPane.setTabComponentAt(0, new JLabel(icon));
>
> - in such a case the test passes for OS X (as well as for Windows, 
> Linux).
> Probably these changes should be reverted after JDK-8151060 fix.

  There is no issue because the ImageIcon with base image  size 35 and 
high-resolution image size 70 is requested to be painted into region 
32x32 for JTabbedPane icon. In this case the base image has enough 
quality to be painted in this region.

  To check that MultiResolutionImage is properly painted for JTabbedIcon 
it is possible to use BaseMultiResolutionImage with images with sizes 
16x16 and 32x32.

Thanks,
Alexandr.

>
> Thanks,
> Alexander
>
> On 3/2/2016 7:15 PM, Alexander Stepanov wrote:
>> Hello Sergey,
>>
>> It fails because of
>> https://bugs.openjdk.java.net/browse/JDK-8151060
>>
>> (plus we need here some tricky check for resolution by the analogy 
>> with 8150258 because of JDK-8150844).
>>
>> Thanks,
>> Alexander
>>
>> On 2/26/2016 4:25 PM, Sergey Bylokhov wrote:
>>> Hi, Alexander.
>>> The test failed on osx 10.11 + retina. Is it expected?
>>>
>>> On 26.02.16 15:53, Alexander Stepanov wrote:
>>>> Hello,
>>>>
>>>> Could you please review the following fix
>>>> http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
>>>> for
>>>> https://bugs.openjdk.java.net/browse/JDK-8150724 ?
>>>>
>>>> Just a single test added.
>>>>
>>>> Thanks,
>>>> Alexander
>>>
>>>
>>
>



More information about the awt-dev mailing list