<AWT Dev> [9] Review request for 8149849 [hidpi] DnD issues (cannot DnD from JFileChooser to JEditorPane or other text component) when scale > 1

[Phil Race]

+1

-phil.

On 03/15/2016 08:31 AM, Sergey Bylokhov wrote:
> On 15.03.16 18:24, Alexandr Scherbatiy wrote:
>>
>>   Could you review the updated fix:
>>    http://cr.openjdk.java.net/~alexsch/8149849/webrev.02/
>>
>>    The test is renamed to DNDTextToScaledArea.
>
> looks fine, thanks.
>
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 3/11/2016 12:08 PM, Phil Race wrote:
>>> As well as Swing I think the sustaining org also used to do this once
>>> upon a time
>>> but I personally find it non-informative and the @bug tag tells me
>>> this anyway ..
>>>
>>> -phil.
>>>
>>> On 03/11/2016 11:27 AM, Sergey Bylokhov wrote:
>>>> On 11.03.16 22:17, Alexandr Scherbatiy wrote:
>>>>>
>>>>> Could you review the updated fix:
>>>>>    http://cr.openjdk.java.net/~alexsch/8149849/webrev.01/
>>>>>
>>>>> On 3/10/2016 6:11 AM, Sergey Bylokhov wrote:
>>>>>> Looks fine.
>>>>>> Small typo in the test: * @test @bug 8149849
>>>>>     The typo is fixed.
>>>>>> Probably the name of the test can be changed to something like
>>>>>> HiDPIDrag etc.
>>>>>       The bugBugNumber is a common name convention for swing tests.
>>>>
>>>> I guess it is used by you only=) All other people use according to:
>>>> http://openjdk.java.net/jtreg/faq.html#question2.14
>>>>
>>>> up2you. Looks fine.
>>>>
>>>>
>>>>>> Does it work on all platforms?
>>>>>     Yes, the test passes on Linux and Mac OS X.
>>>>>
>>>>>    Thanks,
>>>>>     Alexandr.
>>>>>>
>>>>>>
>>>>>> On 10.03.16 16:07, Alexandr Scherbatiy wrote:
>>>>>>>
>>>>>>> Hello,
>>>>>>>
>>>>>>> Could you review the fix:
>>>>>>>    bug: https://bugs.openjdk.java.net/browse/JDK-8149849
>>>>>>>    webrev: http://cr.openjdk.java.net/~alexsch/8149849/webrev.00
>>>>>>>
>>>>>>>    Rescaling for native drag coordinates is added.
>>>>>>>
>>>>>>>   Thanks,
>>>>>>>   Alexandr.
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>
>