<AWT Dev> <AWT dev>[9] Review request for 8151333: Some AWT functions may access an array outside of its bounds

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Mar 29 14:00:48 UTC 2016


The fix looks good to me.

Thanks,
Alexandr.

On 22/03/16 17:17, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8151333
> webrev: http://cr.openjdk.java.net/~ssadetsky/8151333/webrev.00/
>
> This just suppose to be a potential issue. It is discovered by 
> AddressSanitizer.
> When Xinerama is used the number of screens that is seen by WM is 
> always 1. But X11GraphicsDevice#getDisplayMode() may be called with 
> the "real" screen number and this is not checked in the native code 
> and thus may cause incorrect memory addressing.
> As a solution a check for validity of the screen number is added.
> Test would require writing native code, so noreg-hard label is added.
>
> --Semyon



More information about the awt-dev mailing list