<AWT Dev> <AWT dev>[9] Review request for 8157163: AWT FileDialog does not inherit icon image from parent Frame

Semyon Sadetsky semyon.sadetsky at oracle.com
Tue May 24 06:18:50 UTC 2016



On 5/23/2016 10:58 PM, Sergey Bylokhov wrote:
> On 23.05.16 20:31, Semyon Sadetsky wrote:
>> The bug is about two issues:
>> 1. The window icon is not inherited in case of the AWT file dialog has
>> an owner window. Setting the icon was not implemented for the non-null
>> owner.
>
> this looks fine.
>
>>
>> 2. Requesting screen location of the open file dialog window causes
>> exception. The root cause is the basic implementation of the
>> getLocationOnScreen() method uses native peer window which is not set in
>> case of the file dialog. So the specific implementation is added in the
>> file dialog peer.
>
> Should we check that hwnd is ::isWindow?

It seems sensible to add it: 
http://cr.openjdk.java.net/~ssadetsky/8157163/webrev.01/

--Semyon





More information about the awt-dev mailing list