<AWT Dev> <AWT dev>[9] Review request for 8075516: Deleting a file from either the open or save java.awt.FileDialog hangs.
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Tue May 31 13:22:56 UTC 2016
Looks fine.
On 31.05.16 10:15, Semyon Sadetsky wrote:
> Please review the updated webrev:
> http://cr.openjdk.java.net/~ssadetsky/8075516/webrev.01/
>
> changes: several improvements for the manual test
>
> --Semyon
>
> On 5/30/2016 8:25 PM, Sergey Bylokhov wrote:
>> The fix looks fine, a few notes about the test:
>> - Should the Frame be disposed like FileDialog?
>> - Probably it will be possible to simplify the test for the tester,
>> and create the folder and files from the test itself and to point the
>> FileDialog to this folder? One of them should be removed and another
>> one should be selected(up2you)
>>
>> On 27.05.16 14:55, Alexandr Scherbatiy wrote:
>>> The fix looks good to me.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>> On 5/20/2016 6:22 PM, Semyon Sadetsky wrote:
>>>> Hello,
>>>>
>>>> Please review fix for JDK9:
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8075516
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8075516/webrev.00/
>>>>
>>>> In Windows 8 OFN dialog starts to use COM requests internally. Since
>>>> that the SendMessage request to the Toolkit thread cannot be used due
>>>> to inability of COM to marshal an outgoing call while processing the
>>>> SendMessage. It causes RPC_E_CANTCALLOUT_ININPUTSYNCCALL error.
>>>> As a solution SendMessage is replaced with PostMessage.
>>>>
>>>> --Semyon
>>>>
>>>
>>
>>
>
--
Best regards, Sergey.
More information about the awt-dev
mailing list