<AWT Dev> <AWT dev>[9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

[Sergey Bylokhov]

Looks fine.

On 03.11.16 14:13, Manajit Halder wrote:
> Hi Sergey,
>
> Thank you for the review comment. Code is modified as per the comment.
> Please review the modified webrev:
>
> http://cr.openjdk.java.net/~mhalder/7153700/webrev.02/
>
> Thanks,
> Manajit
>
>> On 27-Oct-2016, at 5:05 pm, Sergey Bylokhov
>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>
>> Hi, Manajit.
>>
>> 179     if (trackingArea) {
>> 180         [self removeTrackingArea:trackingArea];
>> 181     }
>> I think that the code above is also not necessary(Since this code is
>> executed only once). The pointer trackingArea is not initialized to
>> nil so it can contains some non-nil garbage, and calling
>> removeTrackingArea:trackingArea can cause a crash.
>>
>> On 27.10.16 14:08, Manajit Halder wrote:
>>> Hi Sergey,
>>>
>>> Code is modified to correct a memory leak. Please review the modified
>>> webrev:
>>> _http://cr.openjdk.java.net/~mhalder/7153700/webrev.01/_
>>>
>>> Thanks,
>>> Manajit
>>>
>>>> On 21-Oct-2016, at 1:20 pm, Manajit Halder
>>>> <manajit.halder at oracle.com <mailto:manajit.halder at oracle.com>
>>>> <mailto:manajit.halder at oracle.com>> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Kindly review the fix for JDK9.
>>>>
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-7153700
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~mhalder/7153700/webrev.00/
>>>>
>>>> Issue:
>>>> [macosx] add support for MouseMotionListener to the TrayIcon.
>>>>
>>>> Fix:
>>>> Added MouseMotionListener support for TrayIcon on Mac OS X.
>>>>
>>>> Regards,
>>>> Manajit
>>>
>>
>>
>> --
>> Best regards, Sergey.
>


-- 
Best regards, Sergey.