<AWT Dev> Review Request For 8160766: [TEST_BUG] java/awt/Focus/DisposedWindow

Ajit Ghaisas ajit.ghaisas at oracle.com
Fri Nov 4 05:51:50 UTC 2016


Looks good.

Regards,
Ajit

-----Original Message-----
From: Sergey Bylokhov 
Sent: Thursday, November 03, 2016 4:08 PM
To: Ambarish Rapte; Ajit Ghaisas; Semyon Sadetsky; awt-dev at openjdk.java.net
Subject: Re: Review Request For 8160766: [TEST_BUG] java/awt/Focus/DisposedWindow

HI, Ambarish.
Looks fine, but it seems that you need to make buttonReceivedFocus volatile, since you write/read it from the different thread. You can do this just before the push.

On 27.10.16 18:21, Ambarish Rapte wrote:
> Hi All,
>
>
>
>                 Please review this test bug fix.
>
>                 Bug: https://bugs.openjdk.java.net/browse/JDK-8160766
>
>
>
>                 This is small fix to add waitForIdle & delay. 
> Webrev.00 is for reference of minimal changes.
>
>                 Webrev with minimum changes for review:
> http://cr.openjdk.java.net/~arapte/8160766/webrev.00/
>
>
>
>                 This is an applet based, so would be removing the applet.
>
>                 Final Webrev without applet:
> http://cr.openjdk.java.net/~arapte/8160766/webrev.01/
>
>
>
> Regards,
>
> Ambarish
>
>
>


--
Best regards, Sergey.


More information about the awt-dev mailing list