<AWT Dev> [9] Fix for JDK-8058950 : [TESTBUG] There is no F1 dialog when the case loading, so we can't restore it.

[Ambarish Rapte]

Hi Ajit,
	The changes look fine to me.

Regards,
Ambarish

-----Original Message-----
From: Sergey Bylokhov 
Sent: Friday, September 30, 2016 5:21 PM
To: Ajit Ghaisas; awt-dev at openjdk.java.net; Semyon Sadetsky; Ambarish Rapte
Subject: Re: [9] Fix for JDK-8058950 : [TESTBUG] There is no F1 dialog when the case loading,so we can't restore it.

Looks fine.

On 30.09.16 14:38, Ajit Ghaisas wrote:
> Looking at the issue(JDK-6401700) where this test was introduced, it is clear that this test should run on linux and solaris.
> I have updated the test with appropriate @requires tag.
> http://cr.openjdk.java.net/~aghaisas/8058950/webrev.01/
>
> Request you to review.
>
> Regards,
> Ajit
>
>
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Thursday, September 29, 2016 6:07 PM
> To: Ajit Ghaisas; awt-dev at openjdk.java.net; Semyon Sadetsky; Ambarish Rapte
> Subject: Re: [9] Fix for JDK-8058950 : [TESTBUG] There is no F1 dialog when the case loading,so we can't restore it.
>
> Should this test start on OSX? I think we can tweak the platforms via @req tag.
>
> On 21.09.16 21:04, Ajit Ghaisas wrote:
>> Hi,
>>
>> Bug :
>>      https://bugs.openjdk.java.net/browse/JDK-8058950
>>
>> Issue :
>>     Minimized test frame cannot be restored.
>>
>> Fix :
>>    1. The test fix is quite simple - to introduce delay between frame.setVisible(true) and frame.setExtendedState(Frame.ICONIFIED).
>>    2. I have modified test - not to use Applet. This results in multiple changes when file diff is seen.
>>
>> Webrev :
>>    http://cr.openjdk.java.net/~aghaisas/8058950/webrev.00/
>>
>> Request you to review.
>>
>> Regards,
>> Ajit
>>
>
>
> --
> Best regards, Sergey.
>


-- 
Best regards, Sergey.