<AWT Dev> [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

Alexander Zvegintsev alexander.zvegintsev at oracle.com
Thu Oct 6 12:38:37 UTC 2016


Hi Semyon,

Yes it is, Microsoft defined some set of rules for such case[0].

However it looks redundant and too implementation-specific(which can be 
changed) for me.

Reformatted for 80 chars in place.


[0] 
https://msdn.microsoft.com/en-us/library/windows/desktop/dd391698(v=vs.85).aspx#How_the_Taskbar_Button_Chooses_the_Progress_Indicator_for_a_Group


On 10/6/16 9:23 AM, Semyon Sadetsky wrote:
> Hi Alexander,
>
> 416      * Note that the behavior is undefined when multiple windows 
> is grouped in the task area.
>
> Isn't the above a some kind of simplification?
>
> Could you reformat changed lines to make them following the 80 chars 
> maximum?
>
> --Semyon
>
>
> On 06.10.2016 04:56, Alexander Zvegintsev wrote:
>> Hello,
>>
>> please review the fix
>>
>> http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/00/
>>
>> for the issue
>>
>> https://bugs.openjdk.java.net/browse/JDK-8166594
>>
>>
>> It also fixes two issues to conform the documentation:
>>
>> setting value below 0 doesn't disable progress indication
>>
>> switching from indeterminate to normal state has no effect
>>
>

-- 
Thanks,
Alexander.



More information about the awt-dev mailing list