<AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

[Ajit Ghaisas]

Looks fine.

 

Regards,

Ajit

 

From: Prem Balakrishnan 
Sent: Monday, October 24, 2016 3:16 PM
To: Ajit Ghaisas; Alexander Scherbatiy; Rajeev Chamyal; awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

 

Hi Ajit,

 

Thankyou for the review.

Updated patch as per review comments.

http://cr.openjdk.java.net/~pkbalakr/8168292/webrev.01/ 

 

Regards,

Prem

 

From: Ajit Ghaisas 
Sent: Monday, October 24, 2016 2:00 PM
To: Prem Balakrishnan; Alexander Scherbatiy; Rajeev Chamyal; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

 

Hi Prem,

 

    I know this is compilation fix, but still few corrections can be made to the test.

 

1.       Please replace generic imports to specific class imports.

2.       First sentence of the instruction text has a typo - please correct it.

Existing  : "Use see a Frame with a button in it." 

Should be : "User sees a Frame with a button on it."

 

Regards,

Ajit

 

From: Prem Balakrishnan 
Sent: Thursday, October 20, 2016 3:00 PM
To: Alexander Scherbatiy; Rajeev Chamyal; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: <AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

 

Hi,

 

Please review the patch.

Test Bug: https://bugs.openjdk.java.net/browse/JDK-8168292 

Webrev: http://cr.openjdk.java.net/~pkbalakr/8168292/webrev.00/ 

 

Compilation error: Can't find library\: ../../../regtesthelpers 

Fix: updated the library path

 

Regards,

Prem
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20161025/07baca6b/attachment.html>