<AWT Dev> Review request for 8160570: [mac] modal dialog can skip the activation/focus events

[Anton Tarasov]

On 9/5/2016 8:11 PM, Sergey Bylokhov wrote:
> On 01.09.16 17:22, Anton Tarasov wrote:
>>> but both frames are still visible. This is why I wonder, how did you 
>>> close it in the app.
>>
>> You probably missed the fact the dialog is modal.
>
> O_o, correct. No more comments from me. Looks fine. Thanks for the fix.

Thanks for the review. I'll also request for pushing it to 8u-dev as well.

Regards,
Anton.


>
>>
>> Anton.
>>
>>>
>>>>
>>>> Why do I have to dispose all windows in a reg test?
>>>>
>>>> Of course I tested it, on jdk9 of a version matching the date of 
>>>> submitting the fix.
>>>>
>>>> Regards,
>>>> Anton.
>>>>
>>>>>
>>>>>>> --Semyon
>>>>>>>> The problem is thus specific to OSX.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Anton.
>>>>>>>>
>>>>>>>>> On 29 Aug 2016, at 19:30, Semyon Sadetsky
>>>>>>>>> <semyon.sadetsky at oracle.com> wrote:
>>>>>>>>>
>>>>>>>>> Hi Anton,
>>>>>>>>>
>>>>>>>>> is it really OS X only problem? It seems on other platforms 
>>>>>>>>> the peer
>>>>>>>>> focusability is updated in the same way.
>>>>>>>>>
>>>>>>>>> --Semyon
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 6/29/2016 9:04 PM, Anton Tarasov wrote:
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> Please review the fix:
>>>>>>>>>>
>>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8160570
>>>>>>>>>> webrev: http://cr.openjdk.java.net/~ant/JDK-8160570/webrev.0
>>>>>>>>>> <http://cr.openjdk.java.net/%7Eant/JDK-8160570/webrev.0>
>>>>>>>>>>
>>>>>>>>>> The problem is that a modal dialog can skip the activation/focus
>>>>>>>>>> events on OSX.
>>>>>>>>>> The fix is to cache the focusability state of the Window peer
>>>>>>>>>> earlier, in its ctor.
>>>>>>>>>> Please find more details in JIRA.
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Anton.
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> -- 
>>>>> Best regards, Sergey.
>>>>
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>
>