<AWT Dev> [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

[Semyon Sadetsky]

Looks good.

--Semyon


On 9/8/2016 6:02 PM, Alexander Zvegintsev wrote:
> Initially showWindowWithoutWarningBanner was added to deny the new API 
> functions invocation without permission check,
>
> but now it seems redundant, so I left only canProcessApplicationEvents 
> in the new webrev:
>
> cr.openjdk.java.net/~azvegint/jdk/9/8164536/02/
>
> -- 
> Thanks,
> Alexander.
>
> On 09/08/2016 04:53 PM, Sergey Bylokhov wrote:
>> On 31.08.16 3:27, Alexander Zvegintsev wrote:
>>> Hi Sergey,
>>>
>>> It could be, but actually RuntimePermission is used by eawt(sure we can
>>> change it too, but I don't see a point)
>>
>> It is still unclear to me why in most of the place we check two 
>> permissions? Can you please clarify what is the purpose of 
>> canProcessApplicationEvents and showWindowWithoutWarningBanner and 
>> why both are related for example to removeAppEventListener() method.
>>
>>>
>>> Please see the updated webrev:
>>>
>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/01/
>>>
>>> -- 
>>> Thanks,
>>> Alexander.
>>>
>>> On 30.08.2016 22:44, Sergey Bylokhov wrote:
>>>> Hi, Alexander.
>>>> Probably the name of this permission can be added to 
>>>> AWTPermissions.java?
>>>> I am not sure why some of the methods require
>>>> "canProcessApplicationEvents" permission. For example
>>>> Taskbar.getTaskbar()? I guess Desktop.getDesktop() is used a template
>>>> but it does not throw such exceptions and/or require similar 
>>>> permissions.
>>>>
>>>> On 30.08.16 21:58, Alexander Zvegintsev wrote:
>>>>> Hello,
>>>>>
>>>>> Please review the fix
>>>>>
>>>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/00/
>>>>>
>>>>> for the issue
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8164536
>>>>>
>>>>> This fix add check for canProcessApplicationEvents runtime
>>>>> permission(currently used by eawt) for Desktop and Taskbar classes.
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>