<AWT Dev> RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

Phil Race philip.race at oracle.com
Fri Sep 30 19:01:38 UTC 2016


Our helpful SQE engineer has verified that this works as well as previously.
And I've done some basic testing myself on Ubuntu 16.04, so "+1" 
(meaning approved).

-phil.

On 09/27/2016 08:41 AM, Alan Burlison wrote:
> On 26/09/2016 23:42, Philip Race wrote:
>
>
>>>> So that looks like it should work although the duplicate
>>>> definition irks. Can we remove the static and have it just be
>>>> extern declared in XWindow.c ?
>>>
>>> Absolutely - I didn't particularly like it either but I was a bit
>>> wary of adding a new external symbol. Is the current name OK?
>
> Done, new webrev at http://cr.openjdk.java.net/~alanbur/JDK-8165232.v2/
>
>>>> For testing can you submit a jprt job and I'll see if I can
>>>> rustle up some SQE support to identify any tests that might be
>>>> good to run.
>
> JPRT run on the v2 patch is clean.
>



More information about the awt-dev mailing list