<AWT Dev> [9] Review request for 8164473: [TEST_BUG] Series of modal/focus tests fail always on Unity

Sergey Bylokhov sergey.bylokhov at oracle.com
Thu Apr 6 16:12:11 UTC 2017


Hi, Semyon.
I have a few comments:
 - Looks like Applet machinery and html file are unnecessary in the test since it has the main method anyway.
 - "waitTillShown" is not used anymore?
 - The check for «Mtoolkit» can be removed, this toolkit was removed in jdk7.
 - It will be good to change invokeLater to invokeAndWait, so you will get an exception(if any) immediately.



> 
> bug:https://bugs.openjdk.java.net/browse/JDK-8164473
> 
> webrev: http://cr.openjdk.java.net/~ssadetsky/8164473/webrev.00/
> 
> Stability of ModalExcludedWindowClickTest was improved. The rest tests mentioned in the bug are stably pass after JDK-8161910 is fixed.
> 
> Tested on dual-screen Ubuntu 16.04.
> 
> --Semyon
> 



More information about the awt-dev mailing list