<AWT Dev> [9] RFR(XXS): 8178911: Building of awt_Window.cpp fails on Windows with VS2010

Volker Simonis volker.simonis at gmail.com
Wed Apr 19 12:09:44 UTC 2017


Cool!
I totally forgot about the jdk9-client repository :)
I'll close the new bug as duplicate.

Thanks,
Volker


On Wed, Apr 19, 2017 at 3:32 PM, Sergey Bylokhov
<sergey.bylokhov at oracle.com> wrote:
> Hi, Volker.
> It seems that it was fixed already by
> https://bugs.openjdk.java.net/browse/JDK-8177137
> Will be available in jdk9-dev soon.
>
>
> Hi,
>
> I'd kindly like to request the inclusion of the following trivial fix
> into jdk9 to keep it buildable with VS2010:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2017/8178911/
> https://bugs.openjdk.java.net/browse/JDK-8178911
>
> I know that VS2010 isn't Oracle's default compiler for Windows, but
> others like SAP are still using it. The fix for JDK-8175293 introduced
> a struct assignment which is not supported by VS2010:
>
> prevScaleRec = { -1, -1, -1 };
>
> The fix is rather trivial and would keep the JDK9 sources buildable with
> VS2010:
>
> prevScaleRec.scaleX = prevScaleRec.scaleY = prevScaleRec.screen = -1;
>
> As this fix only removes some "syntactic sugar" I think it imposes no
> risks at all. The benefits of being able to still build the complete
> jdk 9 with VS2010 justifies in my opinion its inclusion into jdk9,
> even at this stage.
>
> Thank you and best regards,
> Volker
>
>


More information about the awt-dev mailing list