<AWT Dev> [9] Review Request: 8178971 Uncommon formatting and typos in java.desktop module

[Semyon Sadetsky]

On 04/19/2017 12:43 PM, Sergey Bylokhov wrote:

>> Same issues can be found in so many classes of java.desktop
>>
>> grep -rE "\\S+\\s{2,}=|\\S+=\\s{2,}\S+|^\\s{5,5}(public|private|static|final|void)" --include \*.java jdk/src/java.desktop | wc -l
>>
>> 2685 !!!
>>
>> Why you decided to fix only those several?
> This change fix the problem in the public api of java sound which were produced by replacing of tabs to spaces. If you take a look to the output of your grep you will see that it find something different.
>
In this grep output I see absolutely the same 5 spaces indentation 
instead of 4 spaces, multiple spaces  around "=".
The source of those formatting issues maybe the same (replacing tabs by 
spaces). And I did not get why the source is important?

 From the descripton of the bug you pretend:

"Uncommon formatting and typos in java.desktop module"

Then why only javax.sound is considered? A bug tittle issue?

But this contradicts to the webrev you've sent because it contains

src/java.desktop/share/classes/java/awt/image/AbstractMultiResolutionImage.java
src/java.desktop/share/classes/java/awt/package-info.java
src/java.desktop/share/classes/module-info.java

files which are outside javax.sound AFAIK.

Also,

src/java.desktop/share/classes/javax/swing/JComponent.java

3738         * the same functionality and it is handled in {@Component}.

should this mistake be corrected? JComponent is also a public API.

--Semyon