<AWT Dev> [10] Review Request: 8153871 [macosx] Low-level error on OS X 10.11 with DnD in Swing

Sergey Bylokhov sergey.bylokhov at oracle.com
Wed Aug 9 01:49:18 UTC 2017


Hello,
Please review the fix for jdk10.

Bug: https://bugs.openjdk.java.net/browse/JDK-8153871
Webrev can be found at: http://cr.openjdk.java.net/~serb/8153871/webrev.00

We get a native error when we tries to initialize the "NSGraphicsContext" to pass it to the NSEvent. But according the specification [1] NSEvent.context is deprecated, and the method mouseEventWithType() which we use to construct the NSEvent highlights [2] that the context parameter is unused and the nil should be passed.
In the fix we pass nil as suggested.

Note that the test still fail time to time because of [3]

[1] https://developer.apple.com/documentation/appkit/nsevent/1524291-context?language=objc
[2] https://developer.apple.com/documentation/appkit/nsevent/1532495-mouseeventwithtype?language=objc
[3] https://bugs.openjdk.java.net/browse/JDK-8186002


-- 
Best regards, Sergey.


More information about the awt-dev mailing list