<AWT Dev> AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords

Baesken, Matthias matthias.baesken at sap.com
Fri Aug 11 07:28:40 UTC 2017



Ø  I added more headful tests that are only run on windows.  I also added

Ø  some @requires os=windows where obvious.

Ø  I would appreciate a review!

Ø  http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/


Hi Götz, not a reviewer  but I noticed  a few  of the files need  Copyright  year update  , for example

test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java

test/java/awt/im/6396526/IMLookAndFeel.java

test/java/awt/print/PrinterJob/ExceptionTest.java

test/java/awt/print/PrinterJob/ImagePrinting/NullClipARGB.java

test/java/awt/print/PrinterJob/PrintTextPane.java

test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java

test/javax/swing/JInternalFrame/8075314/bug8075314.java

test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java

test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.java

test/javax/swing/text/html/Test4783068.java



Does that one need   tag  printer as well ?

test/java/awt/print/PrinterJob/Margins.java


This  test  got a  very  long line in the  "summary"  of the tagging section, maybe better use 2 lines :

test/javax/print/PrintSE/PrintSE.sh


Otherwise looks ok to me .

Best regards, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170811/8aa3ba10/attachment.html>


More information about the awt-dev mailing list